Always download if image is unsupported

[parneet-guraya]

Fix: #8055

• Image will always be downloaded if unsupported.

[nextcloud-android-bot]

Thanks for your contribution!
A toggle is not the best, as it clutters over time settings.
What about having a second snackbar?

• "Resized images not found. Download image?"
  --> "yes"
• "Do you want to always download it?"

[ZetaTom]

Thank you for this contribution.

I do believe that a simple toggle in the preferences is a suitable solution for this problem. However, I would like to involve @nextcloud/designers in this discussion.

In my testing everything worked as expected. I've made suggestions for some minor improvements.

[ZetaTom]

In my opinion this call should be moved to the calling function. As this function is called setErrorPreviewMessage(), one would not expect for it do start a download. Alternatively, this function could be renamed to some thing like handleUnsupportedImage or unsupportedImageCallback.

[jancborchardt]

To refer to our design guidelines from https://nextcloud.com/design/

Software should get out of the way.
Do things automatically instead of offering configuration options.

So in this case, what is the option supposed to do, and what is the default:

• If it’s off by default, only a tiny fraction of people will enable it anyway
• If it’s on by default, why don’t we just make it so, without the option?

@parneet-guraya what do you think?

EDIT: Also reading the original issue at #8017, the root cause does not seem to be best solved by introducing a setting, but rather by just doing it. :)

[parneet-guraya]

@jancborchardt hi 👋 ,

If it’s on by default, why don’t we just make it so, without the option?

By default we ask for the resized image from the backend instead of full resolution (and only fallback to download full resolution if not supported), to save user's bandwidth. I introduced this preference just to keep the current default.

But, if we keep it always on as only option that'd mean unsupported images will always be downloaded. If that's something we are okay with (maybe @tobiasKaminsky can tell) then yes, we can keep this option on by default.

Let me know what you think.

[jancborchardt]

@parneet-guraya thanks for the explanation. :)

But, if we keep it always on as only option that'd mean unsupported images will always be downloaded.

Yes, I would say that is fine – because people want to view the images. They don’t even know that we normally show only a resized version. So we should not expose implementation details to them and just load it.

[AndyScherzinger]

I also agree with Jan's comment: always on 👍

[parneet-guraya]

always on it is 👍

[parneet-guraya]

@ZetaTom , I pushed the change and as discussed in the comments, unsupported image will always be downloaded.

[ZetaTom]

Thank you for implementing the suggested changes.

Everything worked as expected.

[ZetaTom]

During my testing, these changes worked as expected. However, the preview of the actual image didn't work until I re-opened the file. As this behaves the same for me on master, I think that we can go ahead and merge anyway and address the issue of not loading at another date.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	59	59
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	64	64
Correctness	63	63
Dodgy code	297	297
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	6	6
Performance	53	53
Security	18	18
Total	510	510

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13534.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

@jancborchardt The toggle is no longer visible on the settings screen, and the default action is to always download if the image is unsupported.

Toggle not visible in the settings screen and default action is always download if image is unsupported.