Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - Unify Drawer Menu Item Handling #13513

Merged
merged 14 commits into from
Sep 12, 2024
Merged

BugFix - Unify Drawer Menu Item Handling #13513

merged 14 commits into from
Sep 12, 2024

Commits on Sep 11, 2024

  1. Fix 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e065127 View commit details
    Browse the repository at this point in the history

  2. Remove duplicated logic 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9f9f89b View commit details
    Browse the repository at this point in the history

  3. Only highlight new menu item 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5cb2e3a View commit details
    Browse the repository at this point in the history

  4. Allow to set Menu.NONE 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    06ad7d0 View commit details
    Browse the repository at this point in the history

  5. Reduce lint 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    403b34e View commit details
    Browse the repository at this point in the history

  6. Better flow and menu item selection before opening 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1543685 View commit details
    Browse the repository at this point in the history

  7. Use getMenuItemIdFromTitle 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    cb0e8ba View commit details
    Browse the repository at this point in the history

  8. Remove drawer open event 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ae5cee7 View commit details
    Browse the repository at this point in the history

  9. Change back behaviour of SettingsActivity due to not extending from D… 

    …rawerActivity

Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    92c720e View commit details
    Browse the repository at this point in the history

  10. Remove workaround 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    45d363a View commit details
    Browse the repository at this point in the history

  11. Fix kotlin spotless check 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    79d6c7c View commit details
    Browse the repository at this point in the history

  12. Optimize imports 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    cab8c79 View commit details
    Browse the repository at this point in the history

  13. Compare content and selected drawer menu item 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    530ea26 View commit details
    Browse the repository at this point in the history

  14. Fix for AOSP version 

    Signed-off-by: alperozturk <[email protected]>
    @alperozturk96
    alperozturk96 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5f03cae View commit details
    Browse the repository at this point in the history