Improve Media Player

[parneet-guraya]

Fixes:
#925
#5037
#11810
#7462 [ PlayerService that used legacy media library no longer used so it makes it obsolete I guess?]

Changes Introduced:

• Audio files now can be streamed over network.
• Audio playback in background with nice media style notification.
• Both Audio & Video players can handle commands from Bluetooth and Wired earphones.
• Both Audio & Video players implements MediaSession that means any media controller can connect to it and control it. Example Google Assistant, smart watch etc
• Remove dependency on service that used legacy media for audio playback. yet to remove the files in separate PR.
• Support managing audio focus i.e Audio ducking, Audio focus loss.

Record_2024-09-04-04-53-22.mp4

Notification Styles

Oneplus Android 14

Stock Android 12

Stock Android 13 & 14

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[alperozturk96]

Thank you for your contribution! I've created a Git patch to eliminate the use of the "!!" operator.

force_unwrap1.patch

Could you apply this patch?

Additionally, the use of runBlocking blocks the current thread until it completes. BackgroundPlayerService runs on the main thread. I tested, general flow looks okay. It might be acceptable in this case, but for initNextcloudExoPlayer(), would it be possible to notify the service after this function finishes?

[parneet-guraya]

Thank you for your contribution! I've created a Git patch to eliminate the use of the "!!" operator.

force_unwrap1.patch

Could you apply this patch?

Sure, @alperozturk96

Additionally, the use of runBlocking blocks the current thread until it completes. BackgroundPlayerService runs on the main thread. I tested, general flow looks okay. It might be acceptable in this case, but for initNextcloudExoPlayer(), would it be possible to notify the service after this function finishes?

Ah, I was aware of this forgot to add the comment. I know it would block the main thread it's just that the Nextcloud client needs to be created on background thread. but in that time service already starts and player doesn't get initialized. It doesn't do that much of a task while creating a client so I add a run blocking so to wait for the client.

Also, we're not the one starting the service, it is started when session token is created. So no way we can tell it to start after the client init on background.

since controlling when service starts not in our control. Can we have some other option to inject Exoplayer without having to create client instance? tell me if you have any ideas I will see.

thanks 👍

[alperozturk96]

@parneet-guraya Could you please address the Codacy Static Code Analysis issues and apply a git patch to eliminate the use of the !! operator so we can proceed with the merge? Thanks for your contribution! 💯

[parneet-guraya]

@alperozturk96 hi, applied the patch, also what would you say about use of runBlocking although works fine as intended, maybe you missed but I explained it in my comment above. So, maybe we can move forward with this one and later remove use of this?

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	59	59
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	63	63
Correctness	64	64
Dodgy code	299	299
Experimental	1	1
Internationalization	7	7
Multithreaded correctness	6	6
Performance	53	53
Security	18	18
Total	511	511

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13467.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

@alperozturk96 hi, applied the patch, also what would you say about use of runBlocking although works fine as intended, maybe you missed but I explained it in my comment above. So, maybe we can move forward with this one and later remove use of this?

I agree, no need to block this improvement, thank you 👍