Bugfix change shares database USER_ID type to String #12753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Mayer <[email protected]>
Signed-off-by: Jonas Mayer <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12753.apk |
ZetaTom
approved these changes
Mar 28, 2024
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
alperozturk96
approved these changes
Mar 28, 2024
|
/backport to stable-3.28 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database type for the owners userid for shares was int instead of String (which was assumed everywhere, like "getString" etc.). It seemd to have worked well for short userids but for large userids the data will not be correctly saved. Ids like "12320078498127907419284723" would be converted to "1.23200e24" which leads to following misbehavior for example:
Screen_recording_20240327_220052.webm
Now database type is String. To test this fix / to experience the issue, you need to be logged in as a user with a really long userid (=username / loginname) and share a file or folder with another person on the instance.
Screen_recording_20240327_220139.webm