Fix Screenshot Tests #12701
Closed
Fix Screenshot Tests #12701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alperozturk96
commented
Mar 18, 2024
•
alperozturk96
commented
- Tests written, or not not needed
alperozturk96
force-pushed
the
fix/ss-tests
branch
5 times, most recently
from
50417d6
to
c940876
Compare
alperozturk96
commented
Mar 25, 2024
| @@ -76,9 +76,7 @@ public static SslUntrustedCertDialog newInstanceForEmptySslError(SslError error, | |||
| if (error == null) { | |||
| throw new IllegalArgumentException("Trying to create instance with parameter error == null"); | |||
| } | |||
| if (handler == null) { | |||
There was a problem hiding this comment.
null control already exists for usage of handler. For screenshot tests no need to pass SslErrorHandler. Mockito throws error for it.
|
/rebase |
app/src/androidTest/java/com/owncloud/android/ui/trashbin/TrashbinActivityIT.kt
Outdated
Show resolved
Hide resolved
|
/rebase |
1 similar comment
|
/rebase |
alperozturk96
force-pushed
the
fix/ss-tests
branch
from
2d7f5ab
to
7217d98
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
AndyScherzinger
force-pushed
the
fix/ss-tests
branch
from
75f502c
to
fdbf290
Compare
|
❗ REBASED ❗ |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12701.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12701-Screenshot-blue-Light-15-59 |
|
Out of date due to conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.