Make sync worker only run when needed

[JonasMayerDev]

1. Before running sync worker, check if another sync worker is already running.
   Before in theory 2 sync jobs could run and potentially mess with each other (maybe leads to Excessive file upload conflicts after update to 3.26.0 (not before) #11974)
2. Check if any sync folder is enabled and early exit if not.
3. Only scan the file system if "only charging" is disabled or is charging

• Tests written, or not not needed

[ZetaTom]

In my brief testing everything worked as expected. Although I didn't check any edge cases (what happens when a worker is stuck, for example). This might be out of scope for this pull request.

The suggestions are just a minor change and, in reality, just eye candy.

[JonasMayerDev]

Problem: With current implementation when periodic sync worker is started and immediate filesync is already running because of changed files it will skip periodic sync which is not intended... But it is really unlikely since immediate file sync with changed files should only run for under 1 sec.

[alperozturk96]

We can get rid of repeated codes in WorkManagerExtensions with this code.

private const val TAG = "WorkManager"

fun WorkManager.isWorkRunning(tag: String): Boolean = checkWork(tag, listOf(WorkInfo.State.RUNNING))

fun WorkManager.isWorkScheduled(tag: String): Boolean =
    checkWork(tag, listOf(WorkInfo.State.RUNNING, WorkInfo.State.ENQUEUED))

private fun WorkManager.checkWork(tag: String, stateConditions: List<WorkInfo.State>): Boolean {
    val statuses: ListenableFuture<List<WorkInfo>> = getWorkInfosByTag(tag)
    var workInfoList: List<WorkInfo> = emptyList()

    try {
        workInfoList = statuses.get()
    } catch (e: ExecutionException) {
        Log_OC.d(TAG, "ExecutionException in checkWork: $e")
    } catch (e: InterruptedException) {
        Log_OC.d(TAG, "InterruptedException in checkWork: $e")
    }

    return workInfoList.any { workInfo -> stateConditions.contains(workInfo.state) }
}

[alperozturk96]

Tested didn't came across with any regression

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	72	72
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	66	66
Correctness	73	73
Dodgy code	349	349
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	6	6
Performance	57	57
Security	19	19
Total	580	580

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12372.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.