Make sure upload is only added once to db

[JonasMayerDev]

Make sure that upload can not be added twice to db to help with #11974
Should not harm: Why would user want to add upload twice and not update existing one?
For Example, if an upload failed and the user re-uploads, with this pr it updates the existing failed upload with "in progress" to try to upload it again instead of adding the same upload again and causing a conflict next time failed uploads are retried. (See Video)
In addition to that, fixes some issues that occur when duplicates of same upload are in upload list since most functions assume they find only one upload (see uploads tab in video on master)
Screen_recording_20240108_112327.webm
Master
Screen_recording_20240108_112525.webm
This PR

• Tests written, or not not needed

[ZetaTom]

During my brief tests, this change worked well.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	69	69
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	69	69
Dodgy code	353	353
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	54	54
Security	18	18
Total	542	542

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12345.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[rloutrel]

Thank you 100 times!

It is nice to provide something to fix this. But I am not sure about what you mean with 'if an upload failed' and the consequences of 'with "in progress" to try to upload it again'.
Actually it does not fail, it is just that the work in the backend takes longer than what the application is waiting to validate the upload at the end, like some post upload processing before sending final Ack (it could also append with smaller document and the interrupted connections of smartphone apps). Therefor no new upload should be done to replace it. It would change the problem from 'infinite' upload loop to an 'infinite' replace loop (better for storage, if we exclude hdd/sdd read/write limitations, but still not sufficient).

Instead of that, the existing file and the file to be uploaded should be compared to evaluate if they are equivalent (size+name+md5+sha256 OR something similar OR some download ID) or some other technique to ensure the job has been previously correctly done.