Remove File Upload Service

[alperozturk96]

• Tests written, or not not needed

[alperozturk96]

Some tests are failing due to "Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus"

We can try with newest Espresso Version. Same topic

[alperozturk96]

First we need to merge Use Work Manager For File Download #12308 then we can use common logics for this PR (for e.g removing ServiceConnection logic) as well.

[JonasMayerDev]

Seems like everything is working as before or better...

[ZetaTom]

Other than the one thing I've commented on, which might just be a red herring, this works perfectly.

[codecov]

Codecov Report

Merging #12327 (23c2e25) into master (9492301) will increase coverage by 0.32%.
The diff coverage is 45.74%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #12327      +/-   ##
============================================
+ Coverage     27.61%   27.94%   +0.32%     
- Complexity     3326     3355      +29     
============================================
  Files           621      622       +1     
  Lines         45814    45421     -393     
  Branches       6578     6496      -82     
============================================
+ Hits          12653    12694      +41     
+ Misses        31045    30600     -445     
- Partials       2116     2127      +11     

Files	Coverage Δ
.../src/debug/java/com/nextcloud/test/TestActivity.kt	60.78% <ø> (ø)
...java/com/nextcloud/client/di/ComponentsModule.java	0.00% <ø> (ø)
...main/java/com/nextcloud/client/etm/EtmViewModel.kt	0.00% <ø> (ø)
...tcloud/client/etm/pages/EtmFileTransferFragment.kt	0.00% <ø> (ø)
...c/main/java/com/nextcloud/client/files/Registry.kt	94.33% <ø> (ø)
...rc/main/java/com/nextcloud/client/files/Request.kt	74.19% <ø> (ø)
.../com/nextcloud/client/jobs/BackgroundJobFactory.kt	59.23% <100.00%> (ø)
.../com/nextcloud/client/jobs/BackgroundJobManager.kt	0.00% <ø> (ø)
.../nextcloud/client/jobs/BackgroundJobManagerImpl.kt	62.17% <100.00%> (+0.49%)	⬆️
...va/com/nextcloud/client/jobs/ContactsBackupWork.kt	67.60% <ø> (ø)
... and 60 more

... and 17 files with indirect coverage changes

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	69	69
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	73	73
Dodgy code	360	359
Experimental	2	2
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	6	6
Performance	54	54
Security	18	18
Total	548	547

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12327.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.