Use Work Manager For File Download #12308
Merged
Task list completed / task-list-completed
succeeded
Jan 12, 2024 in 0s
1 / 1 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
| Tests written, or not not needed | Completed |
| Download of folder happens in parallel, which messes with the progress notification. | Incomplete |
| Blue sync icon for a folder is only visible for first download | Incomplete |
| Sync of a folder can not be stopped | Incomplete |
| The blue sync icon you can see on master in the right bottom corner of the folder after starting to sync is not there in this PR. | Incomplete |
| The Notifications on master show exactly one download at a time (notification has consistent name and progress), in this PR the progress jumps and filename changes, I assume it's because of multiple downloads (possibly because the worker tag is based on the name and therefore two download workers can exist, but I am not sure). | Incomplete |
| Sync of folder could be stopped at any time on master the same way the sync was stared, but in this PR I get the option to sync again? | |
| Hope this clarifies what I mean. Sorry, I try to be more precise and show comparisons in the future :) | Incomplete |
| isDownloading does return true if file is in pending downloads in folder download (When folder is being synced the files do not have the sync symbol) | Incomplete |
| Files can not be removed from pending downloads in folder sync | Incomplete |
| You can start the same download multiple times -> Multiple upload worker -> Leads to a lot of bugs | |
| _ Maybe make create worker tag only from user, not from user and file to make sure only one worker is present at a time? | Incomplete |
| isDownloading does return true if file is in pending downloads in folder download (When folder is being synced the files do not have the sync symbol) | Incomplete |
| Files can not be removed from pending downloads in folder sync | Incomplete |
| You can start the same download multiple times -> Multiple upload worker -> Leads to a lot of bugs | |
| _ Maybe make create worker tag only from user, not from user and file to make sure only one worker is present at a time? | Incomplete |
| Download of folder happens in parallel, which messes with the progress notification. | Incomplete |
| Blue sync icon for a folder is only visible for first download | Incomplete |
| Sync of a folder can not be stopped | Incomplete |
Loading