Add Files Action to Search

[alperozturk96]

Behaviour:
https://github.com/nextcloud/android/assets/67455295/d09e263c-4311-4391-8f99-57ed8e46e42f

This feature needed for this bugfix

• Tests written, or not not needed

[JonasMayerDev]

When opening the "Files Action" from search for files in a folder, the top bar indicates / shows folder name as if it would be in this folder but is actually still in root / location where searching started. I think this is a relatively common issue, so could be not related to this PR... Maybe would still be nice to switch to the right folder? On the other hand it could also be good to not switch folders to make handling faster?...
Except this it seems to work fine for me.

[alperozturk96]

When opening the "Files Action" from search for files in a folder, the top bar indicates / shows folder name as if it would be in this folder but is actually still in root / location where searching started. I think this is a relatively common issue, so could be not related to this PR... Maybe would still be nice to switch to the right folder? On the other hand it could also be good to not switch folders to make handling faster?... Except this it seems to work fine for me.

Top Bar title cleared when user tap to files action. You can check it.

Regarding other alternative which is showing files action directly inside the search fragment it's not easy because current search functionality in our project. When a user performs a search within a list, the app redirects them to a different fragment. Additionally, each search initiates a network call, and selecting a specific file requires users to navigate back to the previous screen, disrupting the user experience and obscuring the visual feedback provided by the application.
To enhance the user experience by creating a seamless search, selection, and file action process, several changes need to be made. In my opinion, the proposed solution adequately addresses these problems.

If you agree with this evaluation, please give your approval for the Pull Request so that we can proceed with bug fixes and further refinements.

[tobiasKaminsky]

For me it does not work.
When clicking on "three dots" of a search item, it opens root folder in background.
This looks different in your video, and seems also be working for Jonas.

EDIT: after reviewing above video, it is the same.
So I think this is a bit wrong, as still the search view should be shown.
Imagine that an user accidently clicks on "three dots" for wrong file and then needs to search again.

[alperozturk96]

For me it does not work. When clicking on "three dots" of a search item, it opens root folder in background. This looks different in your video, and seems also be working for Jonas.

EDIT: after reviewing above video, it is the same. So I think this is a bit wrong, as still the search view should be shown. Imagine that an user accidently clicks on "three dots" for wrong file and then needs to search again.

It's same for selecting file. If user tap wrong file needs to search again. So the question has to be asked here are we going to change all search functionality with better selection and showing files action or do we leave the selection process as it is.

Given the current structure of the project, this solution seems appropriate.

[alperozturk96]

/rebase

[alperozturk96]

/rebase

[alperozturk96]

/rebase

[alperozturk96]

/rebase

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	70	70
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	68	68
Dodgy code	360	360
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	55	55
Security	18	18
Total	549	549

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12209.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[JonasMayerDev]

Works for me :)

1 Approval adequate