Update M3 library, Increase target sdk to 34

[alperozturk96]

• Tests written, or not not needed

[alperozturk96]

Needed for latest M3 library

[ZetaTom]

Seems to work well during my brief tests. Have the behavioural changes of Android 14 been addressed already?

According to the lint bot there are apparently some missing super calls in various activities that haven't been changed by this pull request. Maybe something else or some requirements have changed in the meantime?

[alperozturk96]

As far as I know regarding behavioural changes on Android 14 nothing specifically done in codebase. Regardless targetSdkVersion if device have Android 14 that changes automatically done so increasing or decreasing targetSdkVersion not going to effect anything on Android 14 devices. @ZetaTom We must check "Behavior changes" for Android 14 device but I think it's not related to this PR.

Seems like after targetSdkVersion change Linter seeing those intentionally not called super method as warning. However, I see that the default action is not requested in those activities. If we call super methods, the behavior of the application may change. In this case we can use "Suppress" annotation.

[tobiasKaminsky]

Unit tests are failing to compile:

Task :app:compileGplayDebugUnitTestKotlin FAILED
e: file:///home/runner/actions-runner/_work/android/android/app/src/test/java/com//client/core/LocalConnectionTest.kt:68:39 Overload resolution ambiguity:
public open fun bindService(p0: Intent, p1: ServiceConnection, p2: Context.BindServiceFlags): Boolean defined in android.content.Context
public abstract fun bindService(p0: Intent, p1: ServiceConnection, p2: Int): Boolean defined in android.content.Context
e: file:///home/runner/actions-runner/_work/android/android/app/src/test/java/com//client/core/LocalConnectionTest.kt:79:25 None of the following functions can be called with the arguments supplied:
public open fun bindService(p0: Intent, p1: ServiceConnection, p2: Context.BindServiceFlags): Boolean defined in android.content.Context
public abstract fun bindService(p0: Intent, p1: ServiceConnection, p2: Int): Boolean defined in android.content.Context
e: file:///home/runner/actions-runner/_work/android/android/app/src/test/java/com//client/core/LocalConnectionTest.kt:79:73 The boolean literal does not conform to the expected type Unit
e: file:///home/runner/actions-runner/_work/android/android/app/src/test/java/com//client/core/LocalConnectionTest.kt:84:26 None of the following functions can be called with the arguments supplied:
public open fun bindService(p0: Intent, p1: ServiceConnection, p2: Context.BindServiceFlags): Boolean defined in android.content.Context
public abstract fun bindService(p0: Intent, p1: ServiceConnection, p2: Int): Boolean defined in android.content.Context
w: Detected multiple Kotlin daemon sessions at kotlin/sessions

[tobiasKaminsky]

Android 14 specific can and should be discussed in #11791

[tobiasKaminsky]

Tests are failing to compile

[alperozturk96]

/rebase

[alperozturk96]

/rebase

[alperozturk96]

/rebase

[AndyScherzinger]

@alperozturk96 has conflicts on rebase (!)

[alperozturk96]

/rebase

[alperozturk96]

/rebase

[AndyScherzinger]

@alperozturk96 you need to rebase yourself, since you will have to resolve conflicts which you originally resolved during pulling in master. So the rebase comment won't work.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	75	75
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	70	70
Dodgy code	363	363
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	58	58
Security	18	18
Total	557	557

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12106.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[AndyScherzinger]

Unit tests are fine, only codecov upload fails (not related) and Drone failures are also not related.

[AndyScherzinger]

@tobiasKaminsky @ZetaTom works for my on my phone, however I didn't check for the behavioral changed but as stated by Tobias are to be discussed in the or ticket. So for me the PR is good to go.