Bugfix Check Network Connection When File Item Clicked #12093

alperozturk96 · 2023-10-25T10:46:44Z

Tests written, or not not needed

Signed-off-by: alperozturk <[email protected]>

Signed-off-by: github-actions <[email protected]>

Signed-off-by: alperozturk <[email protected]>

…tored-message-about-unreachable-server-still-present-9652182' into bugfix/Despite-connection-is-restored-message-about-unreachable-server-still-present-9652182

Signed-off-by: github-actions <[email protected]>

ZetaTom

Refactoring is a necessary effort, but it is generally considered good practise to keep pull requests as modular as possible. I would suggest moving all changes, not strictly needed to fix the issue at hand, into a separate pull request.

Signed-off-by: alperozturk <[email protected]>

Signed-off-by: github-actions <[email protected]>

alperozturk96 · 2023-10-31T12:16:13Z

@ZetaTom I agree. Single responsibility in PR is important. I will revert those changes (enhanced switch case, requireActivity, requireContext usages)

Signed-off-by: alperozturk <[email protected]>

…tored-message-about-unreachable-server-still-present-9652182' into bugfix/Despite-connection-is-restored-message-about-unreachable-server-still-present-9652182

Signed-off-by: alperozturk <[email protected]>

tobiasKaminsky · 2023-11-06T14:45:33Z

app/src/main/java/com/nextcloud/client/network/ConnectivityObserver.kt

+import android.net.ConnectivityManager
+import android.net.NetworkCapabilities
+
+object ConnectivityObserver {


We already have ConnectivityService for this.
Please use/combine those.

Signed-off-by: alperozturk <[email protected]>

…age-about-unreachable-server-still-present-9652182

tobiasKaminsky · 2023-11-10T08:15:03Z

app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java

@@ -36,7 +37,7 @@
 import androidx.core.net.ConnectivityManagerCompat;
 import kotlin.jvm.functions.Function1;

-class ConnectivityServiceImpl implements ConnectivityService {
+public class ConnectivityServiceImpl implements ConnectivityService {


This is implemention of an interface.
Please add the new function to its interface.

tobiasKaminsky · 2023-11-10T08:15:29Z

app/src/main/java/com/owncloud/android/ui/activity/FileActivity.java

@@ -240,6 +241,12 @@ protected void onCreate(Bundle savedInstanceState) {
        }
    }

+    public void checkInternetConnection() {
+        if (ConnectivityServiceImpl.isConnected(this)) {


When it is via interface you can use "connectivityService", which is injected.

tobiasKaminsky

Use interface

Signed-off-by: alperozturk <[email protected]>

alperozturk96 · 2023-11-10T09:27:03Z

@tobiasKaminsky Interface used

Signed-off-by: alperozturk <[email protected]>

ZetaTom

During my testing, I've found that there are certain cases where the message disappears even though the server is unavailable. For example, if you open a media preview while the server is stopped.

alperozturk96 · 2023-11-15T10:13:01Z

@ZetaTom When user don't have internet I am always seeing Server not available message. Could you share video?

ZetaTom · 2023-11-21T08:53:26Z

@alperozturk96, the message disappears if the device is online but the server isn't.

server_availability.webm

alperozturk96 · 2023-11-21T09:01:10Z

@ZetaTom I assume you expect to still see the message if our backend not available if yes then my question will be our backend providing heartbeat API? So I can check backend health (server availability)?

Update:

I talked with @tobiasKaminsky within the scope of this PR this implementation sufficient. However we can add that feature in different PR we need to collaborate backend first of course.

Signed-off-by: alperozturk <[email protected]>

tobiasKaminsky · 2023-12-03T08:18:04Z

/rebase

Signed-off-by: alperozturk <[email protected]>

github-actions · 2023-12-05T08:53:44Z

Codacy

Lint

Type	master	PR
Warnings	74	74
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	70	70
Dodgy code	359	359
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	58	58
Security	18	18
Total	553	553

github-actions · 2023-12-05T08:59:30Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12093.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions · 2023-12-05T09:17:47Z

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

alperozturk96 · 2023-12-06T09:14:29Z

/backport to stable-3.27

Check network connection when file item clicked

bfccb3b

Signed-off-by: alperozturk <[email protected]>

alperozturk96 added the 3. to review label Oct 25, 2023

alperozturk96 requested review from tobiasKaminsky and ZetaTom October 25, 2023 10:46

alperozturk96 and others added 5 commits October 25, 2023 14:16

Fix code analytics

497faaa

Signed-off-by: alperozturk <[email protected]>

Analysis: update lint results to reflect reduced error/warning count

55c7aca

Signed-off-by: github-actions <[email protected]>

Merge master

e202ce3

Signed-off-by: alperozturk <[email protected]>

Merge remote-tracking branch 'origin/bugfix/Despite-connection-is-res…

af0ea73

…tored-message-about-unreachable-server-still-present-9652182' into bugfix/Despite-connection-is-restored-message-about-unreachable-server-still-present-9652182

Analysis: update lint results to reflect reduced error/warning count

1ae36e9

Signed-off-by: github-actions <[email protected]>

ZetaTom reviewed Oct 30, 2023

View reviewed changes

alperozturk96 requested a review from AndyScherzinger October 31, 2023 10:21

alperozturk96 and others added 2 commits October 31, 2023 11:22

Merge master

95931f2

Signed-off-by: alperozturk <[email protected]>

Analysis: update lint results to reflect reduced error/warning count

c3a9060

Signed-off-by: github-actions <[email protected]>

alperozturk96 added 5 commits October 31, 2023 13:23

Revert styling changes

1551873

Signed-off-by: alperozturk <[email protected]>

Merge remote-tracking branch 'origin/bugfix/Despite-connection-is-res…

a37e564

…tored-message-about-unreachable-server-still-present-9652182' into bugfix/Despite-connection-is-restored-message-about-unreachable-server-still-present-9652182

Optimize imports

6dbf383

Signed-off-by: alperozturk <[email protected]>

Remove extra space in uploadFiles

a79ba9d

Signed-off-by: alperozturk <[email protected]>

Merge master

32d1e25

Signed-off-by: alperozturk <[email protected]>

alperozturk96 requested a review from JonasMayerDev November 6, 2023 09:30

tobiasKaminsky reviewed Nov 6, 2023

View reviewed changes

Use ConnectivityServiceImpl

4f7b486

Signed-off-by: alperozturk <[email protected]>

alperozturk96 requested review from tobiasKaminsky and ZetaTom November 8, 2023 15:05

alperozturk96 and others added 3 commits November 9, 2023 12:00

Merge master

0803ecc

Signed-off-by: alperozturk <[email protected]>

Merge master

8ef5721

Signed-off-by: alperozturk <[email protected]>

Merge branch 'master' into bugfix/Despite-connection-is-restored-mess…

71d2983

…age-about-unreachable-server-still-present-9652182

tobiasKaminsky reviewed Nov 10, 2023

View reviewed changes

tobiasKaminsky requested changes Nov 10, 2023

View reviewed changes

Use interface rather than service

07bb2f4

Signed-off-by: alperozturk <[email protected]>

alperozturk96 requested a review from tobiasKaminsky November 10, 2023 09:27

Remove public access modifier

0541fbc

Signed-off-by: alperozturk <[email protected]>

ZetaTom reviewed Nov 15, 2023

View reviewed changes

alperozturk96 requested a review from ZetaTom November 15, 2023 11:52

alperozturk96 added 4. to release 2. developing and removed 3. to review 4. to release labels Nov 22, 2023

alperozturk96 added 2 commits November 22, 2023 09:28

Merge master

c9ecd1b

Signed-off-by: alperozturk <[email protected]>

Add missing interface method to tests

c380ff1

Signed-off-by: alperozturk <[email protected]>

alperozturk96 added 4. to release and removed 2. developing labels Nov 22, 2023

JonasMayerDev approved these changes Dec 4, 2023

View reviewed changes

Merge master

8be0dbe

Signed-off-by: alperozturk <[email protected]>

backportbot-nextcloud bot added the backport-request label Dec 6, 2023

tobiasKaminsky merged commit 0e27b34 into master Dec 11, 2023
20 of 21 checks passed

delete-merged-branch bot deleted the bugfix/Despite-connection-is-restored-message-about-unreachable-server-still-present-9652182 branch December 11, 2023 07:13

tobiasKaminsky removed the backport-request label Mar 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix Check Network Connection When File Item Clicked #12093

Bugfix Check Network Connection When File Item Clicked #12093

alperozturk96 commented Oct 25, 2023 •

edited by AndyScherzinger

Loading

ZetaTom left a comment

alperozturk96 commented Oct 31, 2023

tobiasKaminsky Nov 6, 2023

tobiasKaminsky Nov 10, 2023

tobiasKaminsky Nov 10, 2023

tobiasKaminsky left a comment

alperozturk96 commented Nov 10, 2023

ZetaTom left a comment

alperozturk96 commented Nov 15, 2023

ZetaTom commented Nov 21, 2023

alperozturk96 commented Nov 21, 2023 •

edited

Loading

tobiasKaminsky commented Dec 3, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

alperozturk96 commented Dec 6, 2023

Bugfix Check Network Connection When File Item Clicked #12093

Bugfix Check Network Connection When File Item Clicked #12093

Conversation

alperozturk96 commented Oct 25, 2023 • edited by AndyScherzinger Loading

ZetaTom left a comment

Choose a reason for hiding this comment

alperozturk96 commented Oct 31, 2023

tobiasKaminsky Nov 6, 2023

Choose a reason for hiding this comment

tobiasKaminsky Nov 10, 2023

Choose a reason for hiding this comment

tobiasKaminsky Nov 10, 2023

Choose a reason for hiding this comment

tobiasKaminsky left a comment

Choose a reason for hiding this comment

alperozturk96 commented Nov 10, 2023

ZetaTom left a comment

Choose a reason for hiding this comment

alperozturk96 commented Nov 15, 2023

ZetaTom commented Nov 21, 2023

alperozturk96 commented Nov 21, 2023 • edited Loading

tobiasKaminsky commented Dec 3, 2023

github-actions bot commented Dec 5, 2023

Codacy

Lint

SpotBugs

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

alperozturk96 commented Dec 6, 2023

alperozturk96 commented Oct 25, 2023 •

edited by AndyScherzinger

Loading

alperozturk96 commented Nov 21, 2023 •

edited

Loading