Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share screen email selection from contact book #12059

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

surinder-tsys
Copy link
Collaborator

This PR contains following changes:

  1. Contact book implementation for selecting contact email on share screen.
  2. Only showing the contacts which has email id.
  3. Multiple email id contacts will be shown as individual contact. (System contact app)
  4. On selection auto populating the search field.

Screen Recording of the feature:
https://github.com/nextcloud/android/assets/89455194/9f71a1cc-2c45-4bd8-93e3-18bb102123ae

UI Update: Added contact book icon next to search field.
NC_Share_Screen_Contact_Icon

  • Tests written, or not not needed

@AndyScherzinger AndyScherzinger removed their request for review October 18, 2023 10:00
@AndyScherzinger AndyScherzinger force-pushed the nmc/emailShareViaContactBook branch 3 times, most recently from 5891b17 to efca832 Compare November 8, 2023 17:53
@AndyScherzinger AndyScherzinger force-pushed the nmc/emailShareViaContactBook branch 2 times, most recently from e2f9455 to 191a858 Compare November 20, 2023 08:39
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 21, 2023
Copy link

Codacy

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7070
Dodgy code363363
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total557557

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12059.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I took the liberty to optimize the layout a bit for positioning the icon, also moved it from play flavor to general flavor, tested successfully too 👍

@AndyScherzinger
Copy link
Member

Merging, for whatever reason the screenshot tests aren't failing despite me changing the position of the newly introduced icon

@AndyScherzinger AndyScherzinger merged commit 6756b4d into master Nov 21, 2023
17 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nmc/emailShareViaContactBook branch November 21, 2023 20:19
@AndyScherzinger
Copy link
Member

@surinder-tsys thanks a lot for the PR, I made some minor changes to it, see PRs commit. 🎉

Copy link

github-actions bot commented Apr 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants