Bugfix/update folder icons

[alperozturk96]

Instead of showing the icons of the file directly, the needed material icons were overlayed above the folder icon. Because we don't have single folder icon for each state of file. Web application also using overlaying mechanism plus we have more flexibility to apply any icon to folder icon.

• [Done] Tests written

[tobiasKaminsky]

@alperozturk96 this looks off on our UI screenshot tests:
https://www.kaminsky.me/nc-dev/android-integrationTests/12003-Screenshot-blue-Light-11-02/

you can create the same emulator via:
avdmanager create avd -n uiComparison -c 100M -k "system-images;android-27;google_apis;x86" --abi "google_apis/x86"

and run it via:
emulator -avd uiComparison -no-snapshot -gpu swiftshader_indirect -no-window -no-audio -skin 500x833

[AndyScherzinger]

overlays will need to work in dark/light

[alperozturk96]

overlays will need to work in dark/light

If dark mode activated overlay must be dark or vice versa its need to be white. I just noticed that from web app, thanks.

[tobiasKaminsky]

• Check spotlessKotlinCheck fails, but you can run:
  ./gradlew :app:spotlessApply
  to have this automatically fixed.
• Codacy fails too, which you can see when you click on details.
• DCO is required, so please sign all your git commits:
  In your local branch, run: git rebase HEAD~52 --signoff
  Force push your changes to overwrite the branch: git push --force-with-lease origin bugfix/Update-folder-icons

Why analysis fails, I will check.

[tobiasKaminsky]

Are those really failing?
In latest run I only saw location and activity error.
If they are not failing, please remove those comments.

[alperozturk96]

I ran those marked test still fails in my local machine.

[alperozturk96]

The reason why the tests fails is that CI/CD runs on Android 8. My local device is Android 14 so the tests are failing. For example the expected file path is different on newer Android versions.

[ZetaTom]

Given the current commit (1e4e417), the app unfortunately crashes when attempting to open the overflow menu of any folder. However, it works fine for regular files. I'm running Android 11.0 (API 30) on a Pixel 2 emulator.

Stacktrace

2023-10-10 14:03:27.495 19484-19571 FileDataStorageManager  com.nextcloud.client                 D  getFolderContent - start
2023-10-10 14:03:27.500 19484-19571 FileDataStorageManager  com.nextcloud.client                 D  getFolderContent - finished
2023-10-10 14:03:27.601 19484-19484 SyncedFolderProvider    com.nextcloud.client                 E  0 items for remote path = /A available in sync folder db. Expected 1 or greater than 1. Failed to update sync folder db.
2023-10-10 14:03:27.607 19484-19484 AndroidRuntime          com.nextcloud.client                 D  Shutting down VM
2023-10-10 14:03:27.612 19484-19484 AndroidRuntime          com.nextcloud.client                 E  FATAL EXCEPTION: main
                                                                                                    Process: com.nextcloud.client, PID: 19484
                                                                                                    java.lang.NullPointerException: Attempt to invoke interface method 'com.nextcloud.client.preferences.DarkMode com.nextcloud.client.preferences.AppPreferences.getDarkThemeMode()' on a null object reference
                                                                                                    	at com.owncloud.android.utils.DisplayUtils.setThumbnail(DisplayUtils.java:859)
                                                                                                    	at com.nextcloud.ui.fileactions.FileActionsBottomSheet.loadFileThumbnail(FileActionsBottomSheet.kt:145)
                                                                                                    	at com.nextcloud.ui.fileactions.FileActionsBottomSheet.handleState(FileActionsBottomSheet.kt:121)
                                                                                                    	at com.nextcloud.ui.fileactions.FileActionsBottomSheet.access$handleState(FileActionsBottomSheet.kt:65)
                                                                                                    	at com.nextcloud.ui.fileactions.FileActionsBottomSheet$onCreateView$1.invoke(FileActionsBottomSheet.kt:100)
                                                                                                    	at com.nextcloud.ui.fileactions.FileActionsBottomSheet$onCreateView$1.invoke(FileActionsBottomSheet.kt:100)
                                                                                                    	at com.nextcloud.ui.fileactions.FileActionsBottomSheet$sam$androidx_lifecycle_Observer$0.onChanged(Unknown Source:2)
                                                                                                    	at androidx.lifecycle.LiveData.considerNotify(LiveData.java:133)
                                                                                                    	at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:151)
                                                                                                    	at androidx.lifecycle.LiveData.setValue(LiveData.java:309)
                                                                                                    	at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:50)
                                                                                                    	at androidx.lifecycle.LiveData$1.run(LiveData.java:93)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:938)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                    	at android.os.Looper.loop(Looper.java:223)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7656)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

[alperozturk96]

Given the current commit (1e4e417), the app unfortunately crashes when attempting to open the overflow menu of any folder. However, it works fine for regular files. I'm running Android 11.0 (API 30) on a Pixel 2 emulator.
Stacktrace

Could you check with latest commit?

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12003.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	80	80
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	85	85
Dodgy code	434	434
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	59	59
Security	18	18
Total	644	644

[github-actions]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12003-Screenshot-blue-Light-13-10