-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera permission rationale #11520
Camera permission rationale #11520
Conversation
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8280-IT-stable-15-03 |
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8280-IT-master-15-30 |
@@ -443,6 +443,9 @@ public void onRequestPermissionsResult(int requestCode, @NonNull String[] permis | |||
// permission was granted | |||
getFileOperationsHelper() | |||
.uploadFromCamera(this, FileDisplayActivity.REQUEST_CODE__UPLOAD_FROM_CAMERA); | |||
} else if (!shouldShowRequestPermissionRationale(permissions[0])) { | |||
// user CHECKED "never ask again" | |||
DisplayUtils.showSnackMessage(this, R.string.camera_permission_rationale); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With which Android did you test this?
With Android 10 I only have "allow" or "deny"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that can might be the case because we have found this issue in Huawei device.
The issue will only occur in devices where there is option to deny the permission by checking "Don't ask again" (for lower os versions) or "Don't allow" (for OS 11+) devices.
In both the cases no error snackbar shown to the user.
For more test you can check on Android 11+ devices and select "Don't allow". And again if you click on camera option then no permission dialog and message will be shown.
d4fec26
to
917bd5d
Compare
917bd5d
to
3c4dbb6
Compare
@tobiasKaminsky @surinder-tsys I tested with Android 14 emulator. After tap the don't allow, user already not seeing any error message. android_14.mov |
3c4dbb6
to
8822573
Compare
8822573
to
7443459
Compare
0b30011
to
8be45e3
Compare
8be45e3
to
a1fe95c
Compare
This PR is no longer applicable. So closing the PR. |
Pre condition:
App camera permission should not enabled
Step to reproduce:
Actual result:
After allow permission applied successfully but error message coming to set permission manually.
Expected result:
Error message should not come if permission set successfully