#7815 Delayed synchronization

[BatPio]

Fixes #7815
Fixes #2323

• Tests written, or not not needed
  Some tests are written. I'm waiting for suggestions on what else can be tested.

Delay configuration:

[codecov]

Codecov Report

Merging #11278 (3d40c3a) into master (aeb1632) will increase coverage by 0.07%.
The diff coverage is 37.20%.

❗ Current head 3d40c3a differs from pull request most recent head 501d1fe. Consider uploading reports for the commit 501d1fe to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #11278      +/-   ##
============================================
+ Coverage     31.44%   31.52%   +0.07%     
- Complexity     3413     3427      +14     
============================================
  Files           575      577       +2     
  Lines         42018    42146     +128     
  Branches       5660     5664       +4     
============================================
+ Hits          13214    13286      +72     
- Misses        26861    26905      +44     
- Partials       1943     1955      +12     

Impacted Files	Coverage Δ
...com/nextcloud/client/database/NextcloudDatabase.kt	100.00% <ø> (ø)
...cloud/client/database/entity/SyncedFolderEntity.kt	0.00% <0.00%> (ø)
...java/com/nextcloud/client/di/ComponentsModule.java	0.00% <ø> (ø)
...in/java/com/nextcloud/client/jobs/FilesSyncWork.kt	21.95% <0.00%> (-0.18%)	⬇️
...loud/android/datamodel/FilesystemDataProvider.java	4.39% <0.00%> (-0.10%)	⬇️
...oud/android/datamodel/SyncedFolderDisplayItem.java	35.29% <ø> (ø)
...ncloud/android/datamodel/SyncedFolderProvider.java	10.93% <0.00%> (-0.18%)	⬇️
...ain/java/com/owncloud/android/db/ProviderMeta.java	100.00% <ø> (ø)
...cloud/android/ui/activity/SyncedFoldersActivity.kt	20.43% <0.00%> (-0.55%)	⬇️
.../dialog/SyncedFolderPreferencesDialogFragment.java	0.00% <0.00%> (ø)
... and 11 more

[AlvaroBrey]

I haven't tested this yet, especially to see how this will behave with existing autoupload folders. This can't be tested without adressing my first comment below, however.

Having said that, this looks quite promising! Thanks for contributing @BatPio

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8399-IT-master-22-20

[andreapx]

@BatPio is this still a work in progress or has it been abandoned?

[BatPio]

@JonasMayerDev @alperozturk96

Hi, sorry for delay, I updated my branch to master and now I have a problem with check:
"TooManyFunctions - 15/15 - [Class 'SyncedFolderPreferencesDialogFragment' with '15' functions detected. "

Can you give me some suggestions on what can be moved out of this class?

[alperozturk96]

@JonasMayerDev @alperozturk96

Hi, sorry for delay, I updated my branch to master and now I have a problem with check: "TooManyFunctions - 15/15 - [Class 'SyncedFolderPreferencesDialogFragment' with '15' functions detected. "

Can you give me some suggestions on what can be moved out of this class?

You can use

@Suppress("TooManyFunctions")

this annotation to suppress it, or you can create a new class, e.g. DelaySyncDialogManager and move new functions inside it.

[BatPio]

@alperozturk96

Thanks for advice

I couldn't find any example of DialogManager in the project, so I used @Suppress("TooManyFunctions") . I think the presence of showUploadDelayDialog in SyncedFolderPreferencesDialogFragment is acceptable, because they are closely related.

I think MR is ready for CR

[uspecies]

i just wonder what the upper limit for the day value will be? as i guess i may choose everything between 1 to 12 months in days.
So for example 31 days may not satisfy all users #just saying :p

i will start using NC after this PR is released :) cheers!