Allow requesting a specific channel #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffried
force-pushed
the
feature/channel_request
branch
4 times, most recently
from
bf7708f
to
2c6750d
Compare
Signed-off-by: Florian Friedrich <[email protected]>
ffried
force-pushed
the
feature/channel_request
branch
from
2c6750d
to
98cd7c4
Compare
|
@ffried Thanks a lot for your work on this. In general this feature looks useful, unfortunately it changes a lot of the existing code base which I try to keep as minimal as possible. In the not too close future we plan to move the updater server into a more general purpose API to retrieve version information. I will keep you updated on this and link it here. For now I would like to leave this PR open and just want to let you know that we have not over seen it. |
|
@MorrisJobke Thanks for the info! This means I don't need to keep this PR up-to-date (resolving conflicts), correct? |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to resolve #68 by adding support for a
channelquery parameter.The new parameter is mutually exclusive with
versionand ifversionis providedchannelis ignored.The current implementation tries to find the best version by searching for the highest version number with the highest probability. I'm not a 100% sure if this is the best approach, but it should work for now I think.