Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-interpolated deconvolution #906

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix non-interpolated deconvolution #906

wants to merge 7 commits into from

Conversation

gonzaponte
Copy link
Collaborator

The output of the deconvolution without interpolation produces an image with a different size than with interpolation.

Fixes #905.

@gonzaponte gonzaponte force-pushed the fix-deconv-no-interpolation branch 3 times, most recently from 908e2ab to 768e49c Compare October 30, 2024 10:22
gonzaponte
gonzaponte commented Oct 31, 2024
View reviewed changes
Copy link
Collaborator Author

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to reply as a review to reduce the amount of notifications. Let's see how it works.

invisible_cities/reco/deconv_functions.py Show resolved Hide resolved
invisible_cities/reco/deconv_functions.py Show resolved Hide resolved
invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved
invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved
invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved
jwaiton
jwaiton approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@jwaiton jwaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR resolves a difficult to spot issue within the interpolation and improves the clarity of the interpolation process in beersheba. Good work! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwaiton jwaiton jwaiton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beersheba: no interpolation creates an image of different size
2 participants
@gonzaponte @jwaiton