Reduce warnings nrncvode #3158
Reduce warnings nrncvode #3158
Conversation
This comment has been minimized.
This comment has been minimized.
| @@ -3065,8 +3064,7 @@ void PreSyn::deliver(double tt, NetCvode* ns, NrnThread* nt) { | |||
| TQItem* q = ns->p[i].tq_->least(); | |||
| Cvode* cv = (Cvode*) q->data_; | |||
| if (tt < cv->t_) { | |||
| int err = NVI_SUCCESS; | |||
| err = cv->handle_step(nrn_ensure_model_data_are_sorted(), ns, tt); | |||
| cv->handle_step(nrn_ensure_model_data_are_sorted(), ns, tt); | |||
There was a problem hiding this comment.
We should write an error message here. Is anyone able to tell me what we should write?
There was a problem hiding this comment.
Doesn't seem like something a user could do anything about if they encountered it. Therefore, something semi generic would be sufficient?
"warning: cv->handle_step failed with err = {err}"
Not sure it fits the theme of removing unused variables.
|
|
✔️ 31bfffc -> Azure artifacts URL |
| @@ -3065,8 +3064,7 @@ void PreSyn::deliver(double tt, NetCvode* ns, NrnThread* nt) { | |||
| TQItem* q = ns->p[i].tq_->least(); | |||
| Cvode* cv = (Cvode*) q->data_; | |||
| if (tt < cv->t_) { | |||
| int err = NVI_SUCCESS; | |||
| err = cv->handle_step(nrn_ensure_model_data_are_sorted(), ns, tt); | |||
| cv->handle_step(nrn_ensure_model_data_are_sorted(), ns, tt); | |||
There was a problem hiding this comment.
Doesn't seem like something a user could do anything about if they encountered it. Therefore, something semi generic would be sufficient?
"warning: cv->handle_step failed with err = {err}"
Not sure it fits the theme of removing unused variables.
| static int res_ = 0; | ||
| ++res_; |
No description provided.