WIP: Reduce warnings #3139
WIP: Reduce warnings #3139
Conversation
|
✔️ 99bb35b -> Azure artifacts URL |
There was a problem hiding this comment.
I'm generally in favor of this. I reviewed the first 34 files but am not sure I did not make mistakes. What I notice is that occasionally an unused variable is used in a commented out line or false #if block. Generally for debugging. Or an error return is ignored. I wonder if these should be preserved for later decisions about what to do about them.
src/nrncvode/netcvode.cpp
Outdated
| @@ -3065,8 +3064,7 @@ void PreSyn::deliver(double tt, NetCvode* ns, NrnThread* nt) { | |||
| TQItem* q = ns->p[i].tq_->least(); | |||
| Cvode* cv = (Cvode*) q->data_; | |||
| if (tt < cv->t_) { | |||
| int err = NVI_SUCCESS; | |||
| err = cv->handle_step(nrn_ensure_model_data_are_sorted(), ns, tt); | |||
| cv->handle_step(nrn_ensure_model_data_are_sorted(), ns, tt); | |||
There was a problem hiding this comment.
handle_step does return an error status. Should we print a warning if not NVI_SUCCESS?
There was a problem hiding this comment.
Could you write me a message for that?
|
✔️ 655a4f4 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3139 +/- ##
=======================================
Coverage 67.17% 67.17%
=======================================
Files 573 573
Lines 111436 111429 -7
=======================================
Hits 74855 74855
+ Misses 36581 36574 -7 ☔ View full report in Codecov by Sentry. |
|
✔️ 4c2f419 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
alkino
force-pushed
the
cornu/reduce_warnings
branch
from
4c2f419
to
185b496
Compare
|
|
✔️ 185b496 -> Azure artifacts URL |
|
✔️ d26ea08 -> Azure artifacts URL |
No description provided.