Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IVOS/Table by std::map #3083

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Replace IVOS/Table by std::map #3083

merged 8 commits into from
Sep 24, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Sep 22, 2024

No description provided.

@alkino alkino closed this Sep 22, 2024
@alkino alkino reopened this Sep 22, 2024
@alkino alkino closed this Sep 22, 2024
@alkino alkino reopened this Sep 22, 2024
@alkino alkino changed the base branch from master to cornu/remove_xdr September 22, 2024 17:07
Copy link

sonarcloud bot commented Sep 22, 2024

Copy link

✔️ ba62c59 -> Azure artifacts URL

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 67.39%. Comparing base (0c3bfdd) to head (9c4aec1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ivoc/checkpnt.cpp 0.00% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3083      +/-   ##
==========================================
- Coverage   67.40%   67.39%   -0.01%     
==========================================
  Files         573      573              
  Lines      104914   104920       +6     
==========================================
- Hits        70720    70715       -5     
- Misses      34194    34205      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about pwman.cpp? Seems to use declareTable, too.

@alkino
Copy link
Member Author

alkino commented Sep 23, 2024

@matz-e the other one is coming from InterViews itself, so we should not touch it. The 3 I changed are not used into IV so this is fine to remove them ;)

@alkino alkino marked this pull request as draft September 24, 2024 08:22
Base automatically changed from cornu/remove_xdr to master September 24, 2024 10:47
@alkino alkino marked this pull request as ready for review September 24, 2024 10:55
Copy link

✔️ 9c4aec1 -> Azure artifacts URL

@alkino alkino requested a review from matz-e September 24, 2024 12:10
@alkino alkino merged commit 956ae01 into master Sep 24, 2024
36 checks passed
@alkino alkino deleted the cornu/remove_table branch September 24, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants