-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fmt as backend for Printf/Fprintf #3074
Conversation
This way this is possible to redirect the flux for matlab and jupyter
This comment has been minimized.
This comment has been minimized.
4b44d9d
to
ec614d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy to see more C go the way of the dodo
Quality Gate passedIssues Measures |
✔️ 083b829 -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3074 +/- ##
==========================================
- Coverage 67.27% 67.26% -0.01%
==========================================
Files 571 572 +1
Lines 104872 104854 -18
==========================================
- Hits 70548 70530 -18
Misses 34324 34324 ☔ View full report in Codecov by Sentry. |
Fprintf
andPrintf
inutils/logger.hpp
sections.c
a c++ filenrnpy_pr
for onlyPrintf
(same function)fmt::ptr
everywhere this is needed