Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fmt as backend for Printf/Fprintf #3074

Merged
merged 25 commits into from
Sep 12, 2024
Merged

Use fmt as backend for Printf/Fprintf #3074

merged 25 commits into from
Sep 12, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Sep 10, 2024

  • Move Fprintf and Printf in utils/logger.hpp
  • Make sections.c a c++ file
  • Remove nrnpy_pr for only Printf (same function)
  • Use fmt::ptr everywhere this is needed

@alkino alkino changed the base branch from master to cornu/no_more_cerr_cout September 10, 2024 12:14
@alkino alkino marked this pull request as ready for review September 10, 2024 12:34
@alkino alkino changed the title Cornu/modernize printf Use fmt as backend for Printf/Fprintf Sep 10, 2024
@alkino alkino closed this Sep 10, 2024
@alkino alkino reopened this Sep 10, 2024
@bbpbuildbot

This comment has been minimized.

Base automatically changed from cornu/no_more_cerr_cout to master September 11, 2024 10:33
@alkino alkino requested review from 1uc and matz-e September 11, 2024 13:07
src/utils/logger.hpp Outdated Show resolved Hide resolved
src/utils/logger.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to see more C go the way of the dodo

Copy link

sonarcloud bot commented Sep 12, 2024

Copy link

✔️ 083b829 -> Azure artifacts URL

@alkino alkino enabled auto-merge (squash) September 12, 2024 12:50
@alkino alkino merged commit ecbcd45 into master Sep 12, 2024
35 of 36 checks passed
@alkino alkino deleted the cornu/modernize_printf branch September 12, 2024 12:55
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.26%. Comparing base (b8299b9) to head (083b829).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrncvode/tqueue.cpp 0.00% 5 Missing ⚠️
src/nrncvode/netcvode.cpp 0.00% 2 Missing ⚠️
src/nrniv/multisplit.cpp 0.00% 1 Missing ⚠️
src/oc/fileio.cpp 0.00% 1 Missing ⚠️
src/oc/symbol.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3074      +/-   ##
==========================================
- Coverage   67.27%   67.26%   -0.01%     
==========================================
  Files         571      572       +1     
  Lines      104872   104854      -18     
==========================================
- Hits        70548    70530      -18     
  Misses      34324    34324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants