Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Printf/Fprintf instead of std::cout, std::cerr #3073

Merged
merged 16 commits into from
Sep 11, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Sep 9, 2024

This way this is possible to redirect the flux for matlab and jupyter

This way this is possible to redirect the flux for matlab and jupyter
@bbpbuildbot

This comment has been minimized.

Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of occurrences where a newline is stripped. I stopped after a few. Please check them all again.

src/neuron/container/soa_identifier.hpp Outdated Show resolved Hide resolved
src/nrnmpi/nrnmpi_dynam.cpp Outdated Show resolved Hide resolved
src/nrnmpi/nrnmpi_dynam.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost like there should be a println and eprintln to print with a line ending on std{out,err} :)

src/nrniv/nrnpy.cpp Outdated Show resolved Hide resolved
src/nrnoc/init.cpp Outdated Show resolved Hide resolved
@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

✔️ afaf919 -> Azure artifacts URL

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 24 lines in your changes missing coverage. Please review.

Project coverage is 67.27%. Comparing base (8e3de33) to head (afaf919).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/nrniv/nrnpy.cpp 37.50% 10 Missing ⚠️
src/nrnoc/init.cpp 0.00% 3 Missing ⚠️
src/oc/hoc.cpp 25.00% 3 Missing ⚠️
src/ivoc/strfun.cpp 0.00% 2 Missing ⚠️
src/nrniv/nrncore_write/utils/nrncore_utils.cpp 0.00% 1 Missing ⚠️
src/nrnmpi/memory_usage.cpp 0.00% 1 Missing ⚠️
src/nrnoc/treeset.cpp 0.00% 1 Missing ⚠️
src/nrnpython/nrnpy_p2h.cpp 0.00% 1 Missing ⚠️
src/nrnpython/nrnpython.cpp 0.00% 1 Missing ⚠️
src/oc/hoc_oop.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3073   +/-   ##
=======================================
  Coverage   67.26%   67.27%           
=======================================
  Files         571      571           
  Lines      104867   104874    +7     
=======================================
+ Hits        70542    70550    +8     
+ Misses      34325    34324    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alkino alkino enabled auto-merge (squash) September 11, 2024 10:20
@alkino alkino requested review from 1uc and matz-e September 11, 2024 10:20
src/nrniv/nrnpy.cpp Show resolved Hide resolved
@alkino alkino merged commit b8299b9 into master Sep 11, 2024
38 checks passed
@alkino alkino deleted the cornu/no_more_cerr_cout branch September 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::cerr and std::cout break output; they are not equivalent to Fprintf calls
4 participants