Use fmt instead of Sprintf #3041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ e2d7276 -> Azure artifacts URL |
|
|
✔️ ed854d5 -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3041 +/- ##
=======================================
Coverage 67.27% 67.28%
=======================================
Files 571 571
Lines 104911 104913 +2
=======================================
+ Hits 70579 70587 +8
+ Misses 34332 34326 -6 ☔ View full report in Codecov by Sentry. |
1uc
reviewed
Aug 29, 2024
| @@ -49,7 +49,7 @@ static void call_python_with_section(Object* pyact, Section* sec) { | |||
| if (!r) { | |||
| char* mes = nrnpyerr_str(); | |||
| if (mes) { | |||
| Fprintf(stderr, "%s\n", mes); | |||
| std::cerr << mes << std::endl; | |||
There was a problem hiding this comment.
It's not obvious from the definition of Fprinf but it does serve a purpose and using std::cerr and std::cout isn't ideal. See #3052.
1uc
dismissed
their stale review
Review missed the changes implied by using std::cerr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.