-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pt3dstyle logical connection should be at center of soma section (instead of center of contour). #2981
base: master
Are you sure you want to change the base?
Conversation
✔️ 528f82d -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 528f82d -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This reverts commit 528f82d.
✔️ 7b96538 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 5cd3295 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ efc9f28 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
The many CI failures are perplexing. On my machine I have similar errors for
|
✔️ 3e38a26 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Quality Gate passedIssues Measures |
✔️ d6fd24b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Quality Gate passedIssues Measures |
✔️ e4560c7 -> Azure artifacts URL |
Closes #2973
The logical connection after import3d neurolucida3 file should be invariant on
h.define_shape()
.That is, the location of the rest of the tree should not change relative to the soma.
This is accomplished by updating the logical connection point of dendrites at instantiation when the actual 3-d soma section points are known (after processing the contour).
The two (related) substantive changes in this PR are noted in the comments.
Test added