Create a pointer from Prop to Node.
#2768
Conversation
|
@nrnhines I believe we've discussed this issue in a different context. Would something like this make sense? |
|
✔️ 09b49db -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
I've also experienced this issue and am much in favor of this fix. |
|
✔️ 09b49db -> Azure artifacts URL |
|
Thank you! If nobody else needs it right away, I'd propose I first implement the code in NMODL that needs this. Then when that's ready for merging we also merge this first. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2768 +/- ##
==========================================
+ Coverage 67.25% 67.26% +0.01%
==========================================
Files 571 571
Lines 104859 104860 +1
==========================================
+ Hits 70523 70535 +12
+ Misses 34336 34325 -11 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/prop2node
branch
2 times, most recently
from
241b493
to
248de7a
Compare
|
✔️ 248de7a -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
When generating code to call processes from HOC or Python one difficulty can be obtaining the voltage. The voltage is associated with the Node. In the generated code we only have access to the Prop. We don't have access to the voltage via `Memb_list::nodeindices`. When generating code for NRN with NMODL, we don't populate what CoreNEURON calls `v_unused`.
|
✔️ 20e5c17 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ 20e5c17 -> Azure artifacts URL |
|
@nrnhines I'll merge this now, because we use it in #3066 to fix issue #3059. In NMODL I use it to solve similar issues: |
When generating code to call processes from HOC or Python one difficulty can be obtaining the voltage. The voltage is associated with the Node. In the generated code we only have access to the Prop.
We don't have access to the voltage via
Memb_list::nodeindices. When generating code for NRN with NMODL, we don't populate what CoreNEURON callsv_unused.