Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for OcFullMatrix #2474

Merged
merged 20 commits into from
Aug 29, 2023
Merged

Add unit tests for OcFullMatrix #2474

merged 20 commits into from
Aug 29, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Aug 24, 2023

No description provided.

@alkino
Copy link
Member Author

alkino commented Aug 24, 2023

Fix a bug in the same time in getdiag() and setdiag()

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ 1e2b194 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Merging #2474 (58539ec) into master (c3f5089) will increase coverage by 0.66%.
The diff coverage is 96.76%.

@@            Coverage Diff             @@
##           master    #2474      +/-   ##
==========================================
+ Coverage   60.42%   61.09%   +0.66%     
==========================================
  Files         627      628       +1     
  Lines      120823   121089     +266     
==========================================
+ Hits        73013    73976     +963     
+ Misses      47810    47113     -697
Files Changed Coverage Δ
src/ivoc/ocmatrix.h 4.95% <0.00%> (+1.98%) ⬆️
test/unit_tests/matrix.cpp 96.99% <96.99%> (ø)
src/ivoc/ocmatrix.cpp 88.44% <100.00%> (+48.63%) ⬆️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

NEURON ModelDB CI: launching for 5e1562e via its drop url

alexsavulescu
alexsavulescu previously approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@alexsavulescu alexsavulescu dismissed their stale review August 25, 2023 11:44

some tests are failing

@github-actions
Copy link
Contributor

NEURON ModelDB CI: 5e1562e -> download reports from here

@neuronsimulator neuronsimulator deleted a comment from azure-pipelines bot Aug 28, 2023
@azure-pipelines
Copy link

✔️ 36a534f -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ d6e6dde -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 45109a3 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

NEURON ModelDB CI: launching for 45109a3 via its drop url

1uc
1uc reviewed Aug 29, 2023
View reviewed changes
src/ivoc/ocmatrix.cpp Outdated Show resolved Hide resolved
1uc
1uc reviewed Aug 29, 2023
View reviewed changes
src/ivoc/ocmatrix.cpp Outdated Show resolved Hide resolved
1uc
1uc reviewed Aug 29, 2023
View reviewed changes
src/ivoc/ocmatrix.cpp Outdated Show resolved Hide resolved
alkino and others added 2 commits August 29, 2023 09:54
@alkino @1uc
Update src/ivoc/ocmatrix.cpp
f46427b 
Co-authored-by: Luc Grosheintz <[email protected]>
@alkino @1uc
Update src/ivoc/ocmatrix.cpp
58539ec 
Co-authored-by: Luc Grosheintz <[email protected]>
@azure-pipelines
Copy link

✔️ 58539ec -> Azure artifacts URL

@github-actions
Copy link
Contributor

NEURON ModelDB CI: 45109a3 -> download reports from here

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino closed this Aug 29, 2023
@alkino alkino reopened this Aug 29, 2023
@azure-pipelines
Copy link

✔️ 58539ec -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #147317 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino
Copy link
Member Author

alkino commented Aug 29, 2023

@pramodk merge this?

pramodk
pramodk approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I didn't check the test carefully but I see that Luc has reviewed it)

@pramodk pramodk merged commit 2fc6140 into master Aug 29, 2023
33 checks passed
@pramodk pramodk deleted the cornu/add_test_matrix branch August 29, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc left review comments

@pramodk pramodk pramodk approved these changes

@alexsavulescu alexsavulescu alexsavulescu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alkino @bbpbuildbot @pramodk @1uc @alexsavulescu