Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model id is occasionally different from the id of the zip file #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nrnhines
Copy link
Member

NEURON implementation identifiers are not always identical to model entry identifiers. For example, the entry identifier for
the 2005 Traub model is 45539 but the ifc fortran implementation is downloaded if that entry identifier is used for database download. This PR uses the NEURON implementation identifier instead of the entry identifier for

data.Model._object_id

A wrinkle is that a model entry identifier may have multiple distinct NEURON implementation identifiers.

Closes #94

It may be worthwhile to modify this PR so that data.Model._object_id continues to refer to the model entry identifier and add a data.Model._zip_id to refer to the id used for zip file download. Note that the ModelDB.metatdata dictionary now has
NEURON implementation identifiers for keys.
field to refer to the implementation identifier

@nrnhines
Copy link
Member Author

Another implementation method, that makes the existing modeldb API more visible, is to have the modeldb-meta.yaml file additionally contain the "alternative_version" and perhaps the "modeling_application" fields. This might make the processing to determine the proper zip download url more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEURON version of Traub 2005 model should be tested. 82894
1 participant