Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add running multiple directories #119

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Mar 8, 2024

Work on fixing #118.

Changes

  • runmodels can now compile mod files from multiple directories in isolation. Note that for existing models which have model_dir set to multiple dirs (like path1;path2...), those are still compiled together to be consistent with current behavior
  • made model_dir a YAML array instead of a string. As stated above, any existing models that have model_dir set retain the same behavior, except now we are able to compile multiple directory groups (in isolation) instead of just one group, so we can set something like:
    model_dir:
      - 'group1_dir1;group1_dir2'
      - 'group2_dir1;group2_dir2;group2_dir3'
    and those 2 groups will be compiled independently.

Prerequisites

@nrnhines
Copy link
Member

I'm in favor of this. Multiple groups, each with potentially multiple directories seems general enough to cover all cases for building the nrnmech libraries. The only thing I wonder about is if the concept of multiple groups should be replaced by a hierarchical level just below the accession number so that distinct runs for each group can be performed. But that can be deferred to the indefinite future since it potentially involves modification of nrnivmodl. I've lost track of the capabilities and limitations of nrnivmodl and its consistency with nrnivmodl-core. I do know that the last time I changed nrnivmodl it allowed multiple directories and multiple specific file.mod paths allowing spaces in path names (but nrnivmodl_core did not).

@JCGoran JCGoran force-pushed the jelic/add_multiple_directories branch from 2560a6b to 17606b0 Compare March 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants