Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pre-commit & generate actions #162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mdeweerd
Copy link

@mdeweerd mdeweerd commented Jan 5, 2024

  • Add pre-commit (performing linting & formatting of certain files (not committed, on ly reported)).
  • Add action to generate documentation and autotools on updates.

@mdeweerd mdeweerd force-pushed the ci/precommit_generate branch 3 times, most recently from 57118ae to 9ed2201 Compare January 5, 2024 21:19
@suntong
Copy link
Contributor

suntong commented Aug 10, 2024

Hi @ashamedbit, would you take a look at this please?

I'm the DM of the shc Debian package, and shc is not compiling under it (see #167).
if neurobin is still not responding to any of the PRs, would you care to fork and take on all meaningful PRs please?

@suntong
Copy link
Contributor

suntong commented Aug 11, 2024

Thanks for the update @mdeweerd. Would this PR now be superseded by #161 ?

@mdeweerd
Copy link
Author

No, #161 does not superseed this.

More often than not, project owners want a seperate commit for everything. So this is the commit for the flow, the other is a commit for fixes.

I just now merge and pushd the ci flow to check the other branch and removed it again.

Out of curiosity, I also checked #165 with the flow and some memory issues are still reporte by the linting tool:
https://github.com/mdeweerd/shc/actions/runs/10341451154 .

@suntong
Copy link
Contributor

suntong commented Aug 11, 2024

Yeah, that's a major issue, I'll give @ashamedbit a few days to see how he'd response...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants