[ENH] Implemented UI improvements #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmanaem
added
the
pr-minor-breaking
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
surchs
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Really impressive amount of work @rmanaem! Thanks a lot for that 🎉 - and sorry for the long wait for the review. Everything looks very nice, and does what it is supposed to - we'll get to the bottom of the performance issues in a future PR.
That said, I have two main things I would address:
- stateful error handling in the QueryForm component. I think we should not keep state there and instead just compute errors based on props directly (you're doing that for some, but not all errors). See comments
- Snackbar: I think this is a beautiful piece of code and quite a complex achievement. But as I commented inline in the App, there is an existing solution for it and by not using that we now have to maintain a complex piece of code. So I'd say: let's adopt the third party solution instead.
Let me know if you'd like me to push these changes direct to the branch. I understand that we'll have to likely fix #19 then - happy to help with that too.
Some minor comments throughout the PR, take a look
Open
--------- Co-authored-by: rmanaem <[email protected]>
also learn a bit about promises
- learn more about async / await
… `async` function
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[ENH],[FIX],[REF],[TST],[CI],[MNT],[INF],[MODEL],[DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXXFor new features:
For bug fixes: