Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict image modalities to those we support #3

Open
surchs opened this issue Aug 3, 2022 · 5 comments
Open

Restrict image modalities to those we support #3

surchs opened this issue Aug 3, 2022 · 5 comments
Labels
documentation Changes only affect the documentation flag:discuss Flag issue that needs to be discussed before it can be implemented. _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again good first issue Good issue for a new contributor. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome.

Comments

@surchs
Copy link
Contributor

surchs commented Aug 3, 2022

At the moment, anything that is a BIDS suffix will be treated as a imaging modality. It might make more sense for us to have a list of allowable modalities that we support and only encode these.

@surchs surchs added the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Nov 28, 2022
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 29, 2022
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@surchs surchs added documentation Changes only affect the documentation good first issue Good issue for a new contributor. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. and removed _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again labels Dec 5, 2023
@alyssadai
Copy link
Contributor

For the sake of clarifying the issue, is this not the current list of "allowed" modalities we support?

BIDS = {
"anat": NIDM.pf + ":Anatomical",
"func": NIDM.pf + ":Functional",
"dwi": NIDM.pf + ":DiffusionWeighted",
"bval": NIDM.pf + ":b-value",
"bvec": NIDM.pf + ":b-vector",
"T1w": NIDM.pf + ":T1Weighted",
"T2w": NIDM.pf + ":T2Weighted",
"inplaneT2": NIDM.pf + ":T2Weighted",
"bold": NIDM.pf + ":FlowWeighted",
"dti": NIDM.pf + ":DiffusionTensor",
"asl": NIDM.pf + ":ArterialSpinLabeling",
}

I believe there are other types we don't currently include, e.g., EEG. Do you know of a 'master list' of BIDS suffixes somewhere in the docs that could act as a reference?

@surchs
Copy link
Contributor Author

surchs commented Dec 6, 2023

Ah yeah, good point, this probably needs some clarification. afaik BIDS has data types: https://bids-specification.readthedocs.io/en/stable/common-principles.html#definitions and suffixes: e.g. https://bids-specification.readthedocs.io/en/stable/modality-specific-files/magnetic-resonance-imaging-data.html#non-parametric-structural-mr-images

So there are two things to clarify:

  • what does "support" mean, because I don't see a reason we couldn't have EEG data
  • we should probably differentiate data types from suffixes

Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation flag:discuss Flag issue that needs to be discussed before it can be implemented. _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again good first issue Good issue for a new contributor. PR welcome Issue that is not an internal priority, but external PRs to address it are welcome.
Projects
Status: No status
Development

No branches or pull requests

2 participants