Refactor the tests to be clearer and better differentiated between integration and unit #164
Labels
flag:discuss
Flag issue that needs to be discussed before it can be implemented.
_flag:stale
[BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again
maint:coverage
Test coverage improvements that were not included in feature prioritization
maint:refactor
Simplifying or restructuring existing code or documentation.
type:maintenance
Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
We now have a lot of example test files with very minimal differences between them. That is because we are running most of our tests as integration tests (e.g. run through the entire app and looking at it from the outside). That makes sense to make sure that certain input files lead to certain behaviour of the entire app. I don't think this makes as much sense for asserting that very specific error messages are raised or warnings given. For this, we could just use a unit test of the function that does the raising or warning.
In return, we might be able to condense our examples to a couple of "valid" ones with some allowed variability, a couple of ones that should warn, and a couple that should fail outright. it will also make understanding the tests easier and be clearer to reason about if and when these tests fail.
Other potential options:
The text was updated successfully, but these errors were encountered: