-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use msgfmt
to "compile" translations for NUT-Monitor (Python GUI app)
#1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimklimov
added
packaging
CI
Entries related to continuous integration infrastructure (historically also recipes like Makefiles)
python
portability
We want NUT to build and run everywhere possible
labels
Jun 30, 2023
…e gettext msgfmt to compile binary translation files
… translation files
… in other translations
…gardless of ABS paths
It seems that the files would have to go away from Git... different builds/implems of |
Taking sphinx-doc/sphinx#3443 and sphinx-doc/sphinx#3490 into account... |
jimklimov
added a commit
that referenced
this pull request
Jul 3, 2023
…SGFMT - already handled by autotools [#1977]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
Entries related to continuous integration infrastructure (historically also recipes like Makefiles)
packaging
portability
We want NUT to build and run everywhere possible
python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these files were somehow generated by someone and git-committed, and recently happened to be "just changed" by 0bea0af which presumably makes them incorrect binaries.
This PR adds an ability to
make
the translation binary*.mo
files from source*.po
files, and updates the existing ones.For now they remain in git, but maybe to avoid surprises across CI farm on nodes that have
msgfmt
- they should go away and only beEXTRA_DIST
ed into tarballs (should then requiremsgfmt
unlike what this PR offers as a first shot).