Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use msgfmt to "compile" translations for NUT-Monitor (Python GUI app) #1977

Merged
merged 10 commits into from
Jul 3, 2023

Conversation

jimklimov
Copy link
Member

Previously these files were somehow generated by someone and git-committed, and recently happened to be "just changed" by 0bea0af which presumably makes them incorrect binaries.

This PR adds an ability to make the translation binary *.mo files from source *.po files, and updates the existing ones.

For now they remain in git, but maybe to avoid surprises across CI farm on nodes that have msgfmt - they should go away and only be EXTRA_DISTed into tarballs (should then require msgfmt unlike what this PR offers as a first shot).

@jimklimov jimklimov added packaging CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) python portability We want NUT to build and run everywhere possible labels Jun 30, 2023
@jimklimov jimklimov added this to the 2.8.1 milestone Jun 30, 2023
@jimklimov
Copy link
Member Author

It seems that the files would have to go away from Git... different builds/implems of msgfmt (e.g. GNU vs. those on Sun-heritage systems) produce different binaries.

@jimklimov
Copy link
Member Author

Taking sphinx-doc/sphinx#3443 and sphinx-doc/sphinx#3490 into account...

@jimklimov jimklimov merged commit 7d4745c into networkupstools:master Jul 3, 2023
2 checks passed
@jimklimov jimklimov deleted the msgfmt branch July 3, 2023 00:34
jimklimov added a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) packaging portability We want NUT to build and run everywhere possible python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant