[FEATURE] Special handling for log records with "exception" keys #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TYPO3 scheduler catches exceptions of failed tasks and logs messages with the exception as "exception" data property. PHP Exception objects do not get serialized by json_encode() and thus never reach Sentry; all information about them is lost. If a log record contains an 'exception' data key, then the exception itself is logged to Sentry. The log message is kept as breadcrumb. Resolves: networkteam#106
cweiske
force-pushed
the
log-record-exception
branch
from
db5e035
to
cd1fa4f
Compare
|
The original problem - scheduler task failures - is fixed with the core patch mentioned in #106. This patch is not necessary anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPO3 scheduler catches exceptions of failed tasks and logs messages with the exception as "exception" data property.
PHP Exception objects do not get serialized by json_encode() and thus never reach Sentry; all information about them is lost.
If a log record contains an 'exception' data key, then the exception itself is logged to Sentry. The log message is kept as breadcrumb.
Resolves: #106