Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go validation check #462

Closed
wants to merge 0 commits into from
Closed

Conversation

dushyantbehl
Copy link
Contributor

Fixes #461

@dushyantbehl dushyantbehl added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Jul 24, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/flowlogs-pipeline:ac2b952

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ac2b952 make set-flp-image

@jotak
Copy link
Member

jotak commented Jul 24, 2023

like I said on slack, I wonder if we should keep maintaining this MIN_GO_VERSION, as it sounds the same as the built-in go.mod go version

@dushyantbehl
Copy link
Contributor Author

More discussion here..will see what to do next.
netobserv/netobserv-ebpf-agent#164

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #462 (f1b40e5) into main (e2359a8) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is n/a.

❗ Current head f1b40e5 differs from pull request most recent head 8fdebdf. Consider uploading reports for the commit 8fdebdf to get more accurate results

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   66.17%   66.17%           
=======================================
  Files          94       94           
  Lines        6808     6808           
=======================================
  Hits         4505     4505           
  Misses       2047     2047           
  Partials      256      256           
Flag Coverage Δ
unittests 66.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 1, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FLP go validation fails for me on MAC.
2 participants