Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dynamic selection of parent prefix from a set of custom fields #90

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Implement dynamic selection of parent prefix from a set of custom fields #90

wants to merge 20 commits into from

Commits on Nov 11, 2024

  1. Introduce ParentPrefixSelector in spec, status 

    Introduce new conditions for ParentPrefixSelector
Add new custom fields and prefixes for testing ParentPrefixSelector
    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c92daf6 View commit details
    Browse the repository at this point in the history

  2. Log clean up 

    Signed-off-by: Hoanganh.Mai <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    62f0d32 View commit details
    Browse the repository at this point in the history

  3. Implement new restoration hash computation for ParentPrefixSelector 

    Add unit test for restoration hash backward compatibility
Support multiple custom field in a query
Improve CRD validation to reject having both ParentPrefix and ParentPrefixSelector
Reorder column sequence for PrefixClaim
Update kustomization.yaml

Notes:
According to [2], the `oneOf` validation will only come in the next version

Reference:
[1] https://kubernetes.io/blog/2022/09/29/enforce-immutability-using-cel/
[2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation-ratcheting

Signed-off-by: Hoanganh.Mai <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ef35bd5 View commit details
    Browse the repository at this point in the history

  4. Update the sample yaml

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e55a091 View commit details
    Browse the repository at this point in the history

  5. Add testing code for multiple data types in custom fields

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    19d195b View commit details
    Browse the repository at this point in the history

  6. Apply suggestions / fixes from Sergio 

    Co-authored-by: Sergio <[email protected]>
    @henrybear327 @CapiSSS
    henrybear327 and CapiSSS committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5275a11 View commit details
    Browse the repository at this point in the history

  7. Add support for testing sites

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    94686df View commit details
    Browse the repository at this point in the history

  8. Properly fix missing site query

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ab4259c View commit details
    Browse the repository at this point in the history

  9. Fix restoration hash recovery flow

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c8fd63d View commit details
    Browse the repository at this point in the history

  10. Add missing license header

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6a2648c View commit details
    Browse the repository at this point in the history

  11. Update restoration hash computation and restoring from hash flow

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7e70521 View commit details
    Browse the repository at this point in the history

  12. Fix GetAvailablePrefixByParentPrefixSelector by converting tenant and… 

    … site to ID
    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7bad78d View commit details
    Browse the repository at this point in the history

  13. Add ParentPrefixSelector guide empty docs

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6af569c View commit details
    Browse the repository at this point in the history

  14. Add comments

    @henrybear327
    henrybear327 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0f2498c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Replace can't with cannot

    @henrybear327
    henrybear327 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    935a0e2 View commit details
    Browse the repository at this point in the history

  2. Fix missing guarding condition in PrefixController

    @henrybear327
    henrybear327 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b4e22b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Address comments from Joel (part 1)

    @henrybear327
    henrybear327 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5cbb612 View commit details
    Browse the repository at this point in the history

  2. Address comments from Joel (part 2)

    @henrybear327
    henrybear327 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7a8ee83 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Fix typo 

    Co-authored-by: Sergio <[email protected]>
    @henrybear327 @CapiSSS
    henrybear327 and CapiSSS committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1b9b95e View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Add condition

    @henrybear327
    henrybear327 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    80e4a00 View commit details
    Browse the repository at this point in the history