Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile: koi #6329

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

toboil-features
Copy link

koi
Theme scheduling for the KDE Plasma Desktop
https://github.com/baduhai/Koi

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, the upstream profiles are intended to be reasonably secure and this
profile currently doesn't do much.

Please see profile.template and try to add all restrictions that do not break
common use cases.

If an option breaks something (and it's not immediately obvious why), you can
comment it and add a comment at the end of the line explaining why.

See also ktorrent.profile as an example of a KDE-related profile and the wiki:

@kmk3
Copy link
Collaborator

kmk3 commented Jun 8, 2024

@toboil-features

Are you interested in submitting a complete profile?

If not, I think this PR can be closed for now.

Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed.

caps.drop all
ipc-namespace
machine-id
# Add 'net none' to your koi.local if you don't use Sunset/Sunrise feature.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add netfilter below this line.

Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request: add netfilter

Comment on lines +9 to +12
# Restriction below breaks program on Arch.
#include disable-common.inc

include disable-devel.inc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Restriction below breaks program on Arch.
#include disable-common.inc
include disable-devel.inc
include disable-common.inc
include disable-devel.inc

disable-common.inc is a rather important include.

I'd suggest including it and commenting lines in it until you find which ones
are causing problems.

Then for the relevant lines add ignore <entry> before the include.

private-tmp

dbus-user filter
dbus-user.talk org.kde.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dbus-user.talk org.kde.*

This seems overly broad and may allow escaping the sandbox.

Try to figure out more specifically what dbus names the program actually
uses/needs.

@toboil-features toboil-features marked this pull request as draft September 18, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants