profiles: fix misc in kmail and transmission-qt & add kontact.profile #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KMail needs sound access to play notification sounds when an email is received.
Kontact profile largely based on kmail profile with additions, kontact also uses kmail for email so it is sensible to only add "noblacklist"s since the configuration files are shared.
rusty-snake
reviewed
Jul 17, 2023
etc/profile-a-l/kmail.profile
Outdated
| @@ -63,4 +62,7 @@ private-dev | |||
| # writable-run-user is needed for signing and encrypting emails | |||
| writable-run-user | |||
|
|
|||
| # enable desktop notifications | |||
| dbus-user.talk org.freedesktop.Notifications | |||
There was a problem hiding this comment.
This line is ignored because there is no dbus-user filter
There was a problem hiding this comment.
In this case should the user be prompted to add both that line and dbus-user filter to their .local?
|
@rusty-snake All your suggestions are now implemented, thanks again :) |
kmk3
requested changes
Jul 18, 2023
rusty-snake
reviewed
Jul 18, 2023
Comment on lines
+66
to
+67
| #dbus-user.talk org.freedesktop.Notifications | ||
| #dbus-user filter |
There was a problem hiding this comment.
Suggested change
| #dbus-user.talk org.freedesktop.Notifications | |
| #dbus-user filter | |
| #dbus-user filter | |
| #dbus-user.talk org.freedesktop.Notifications |
| @@ -63,4 +62,8 @@ private-dev | |||
| # writable-run-user is needed for signing and encrypting emails | |||
| writable-run-user | |||
|
|
|||
| # to enable desktop notifications, add these commented lines to your kmail.local file | |||
There was a problem hiding this comment.
Suggested change
| # to enable desktop notifications, add these commented lines to your kmail.local file | |
| # To harden kmail.profile, add the following lines to your kmail.local file |
Comment on lines
+12
to
+15
| noblacklist ${HOME}/.cache/kontact | ||
| noblacklist ${HOME}/.config/kontactrc | ||
| noblacklist ${HOME}/.config/kontact_summaryrc | ||
| noblacklist ${HOME}/.local/share/kontact |
| # Persistent local customizations | ||
| include kontact.local | ||
| # Persistent global definitions | ||
| include globals.local |
There was a problem hiding this comment.
globals.local is included twice. Thee redirect_alias template or other redirection profiles.
| @@ -15,6 +15,9 @@ private-bin transmission-qt | |||
| #dbus-user.own com.transmissionbt.Transmission.* | |||
| #dbus-user.talk org.freedesktop.Notifications | |||
|
|
|||
| # System tray support | |||
There was a problem hiding this comment.
Suggested change
| # System tray support | |
| # For system tray support, add the next 2 lines to your transmission-qt.local. | |
| #ignore dbus-user none | |
| #dbus-user filter |
kmk3
changed the title
kmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes "nosound" from kmail.profile to allow notification sounds, and also adds a "dbus-user.talk org.freedesktop.Notifications" to allow notifications to start.
Also adds kontact.profile based on kmail.profile, have been using it and works well.
Also edits transmission-qt.profile to allow systray, commented out as is usually the case with profiles, but better to at least let the user know that it might be necessary to add to .local if they need systray.
EDIT: if the maintainers also prefer to keep "nosound" for kmail, it might make sense to also add it to kontact.profile since I didn't add it there to start, I think it makes sense to either remove it or add a comment letting the user know that sound notifications won't work unless they "ignore nosound"