Run context condition checks only once, after model parsing #1105
Conversation
clinssen
force-pushed
the
symboltable_checks
branch
2 times, most recently
from
eec6c89
to
45f2a47
Compare
clinssen
force-pushed
the
symboltable_checks
branch
4 times, most recently
from
3f1e731
to
0ff3456
Compare
|
Bencher Report| Branch | 1105/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| bencher::mock_0 | 📈 view plot | 1.66 |
| bencher::mock_1 | 📈 view plot | 18.37 |
| bencher::mock_2 | 📈 view plot | 25.10 |
| bencher::mock_3 | 📈 view plot | 34.59 |
| bencher::mock_4 | 📈 view plot | 45.70 |
clinssen
force-pushed
the
symboltable_checks
branch
from
0ff3456
to
ceb4f22
Compare
clinssen
force-pushed
the
symboltable_checks
branch
from
ceb4f22
to
2563e63
Compare
|
| Branch | 1105/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse | 📈 view plot | 4,162,135,894.60 |
pynestml/transformers/assign_implicit_conversion_factors_transformer.py
Outdated
Show resolved
Hide resolved
pynestml/transformers/assign_implicit_conversion_factors_transformer.py
Outdated
Show resolved
Hide resolved
pynestml/utils/model_parser.py
Outdated
| @@ -142,10 +144,14 @@ def parse_file(cls, file_path=None): | |||
| for model in ast.get_model_list(): | |||
| model.accept(ASTSymbolTableVisitor()) | |||
| SymbolTable.add_model_scope(model.get_name(), model.get_scope()) | |||
| Logger.set_current_node(model) | |||
| AssignImplicitConversionFactorsTransformer().transform(model) | |||
There was a problem hiding this comment.
Since this is a Transformer, this should be part of the transformation step. But, I understand that we have to do this before we check the CoCos. We also cannot move this as part of the transformation step and then check the cocos because some cocos transform the model by moving variables across models, especially when synapse models are present (please correct me if I am wrong). So do you think this shouldn't technically be called a Transformer but just a visitor doing the conversion?
There was a problem hiding this comment.
Done! Changed the transformer into a visitor.
|
Thank you for the review! Let's merge as soon as the tests pass. |
This is a spin-off from #1050.
Refactor cocos such that they run only once, after model parsing.
Fixes some other bugs that emerged as part of this refactor. For instance, two cocos turned out to actually make needed changes to the model; the modification part has now been spun off to the new AssignImplicitConversionFactorsTransformer. (I can also make the transformer into a pure visitor; please let me know if you prefer this approach.)
Changes order of operations in compartmental code generator: to prevent symbol not found error, add propagator variable first, then add the update expressions that reference this variable.