Check to see if a Viewer is running and skip the build check #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne. If so, skip building on start.
If no dir exists at all, the program will crash since it still tries to host one
brentyi
approved these changes
Aug 6, 2023
yzslab
pushed a commit
to yzslab/viser
that referenced
this pull request
Oct 20, 2024
…dio-project#74) * Add a check to see if a Viser viewer is already running on your machine. If so, skip building on start. * Swap build dir check and process check If no dir exists at all, the program will crash since it still tries to host one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a line to the Vite config that sets the viewer's process name to "Viser Viewer", and adds a function that uses psutil to check if "Viser Viewer" exists in the process list. If it does and any build exists at all, it skips the build check.
This is mostly to speed up development, since it will stop the client from rebuilding every time an example is restarted while active changes are being made.