Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jonah/sidebar #70

Merged
merged 8 commits into from
Aug 4, 2023
Merged

Jonah/sidebar #70

merged 8 commits into from
Aug 4, 2023

Conversation

jonahbedouch
Copy link
Contributor

Reworks the fixed_sidebar theme option into a control_type option that accepts floating, fixed, and collapsible

  • floating and fixed represent existing functionality with fixed_sidebar being False and True respectively.
  • collapsible loads a sidebar with a button that allows it to be hidden and re-shown
    image
    image

brentyi
brentyi reviewed Aug 3, 2023
View reviewed changes
viser/_message_api.py Outdated Show resolved Hide resolved
@brentyi brentyi merged commit 0e6519e into main Aug 4, 2023
11 checks passed
@brentyi brentyi deleted the jonah/sidebar branch August 4, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahbedouch @brentyi