Faster point clouds + outlines

nerfstudio-project · Feb 8, 2024 · fa3ff41 · fa3ff41
1 parent f5bf1fb
commit fa3ff41
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/viser/client/src/Outlines.tsx b/src/viser/client/src/Outlines.tsx
@@ -107,7 +107,7 @@ export const Outlines = React.forwardRef<THREE.Group, OutlinesProps>(
     const [material] = React.useState(
       () => new OutlinesMaterial({ side: THREE.BackSide }),
     );
-    const { gl } = useThree();
+    const gl = useThree((state) => state.gl);
     const contextSize = gl.getDrawingBufferSize(new THREE.Vector2());
     React.useMemo(() => extend({ OutlinesMaterial }), []);
 

diff --git a/src/viser/client/src/ThreeAssets.tsx b/src/viser/client/src/ThreeAssets.tsx
@@ -89,7 +89,7 @@ export const PointCloud = React.forwardRef<
     colors: Float32Array;
   }
 >(function PointCloud(props, ref) {
-  const { gl, camera } = useThree();
+  const getThreeState = useThree((state) => state.get);
 
   const geometry = new THREE.BufferGeometry();
   geometry.setAttribute(
@@ -125,9 +125,11 @@ export const PointCloud = React.forwardRef<
     material.uniforms.scale.value =
       (props.pointSize /
         Math.tan(
-          (((camera as THREE.PerspectiveCamera).fov / 180.0) * Math.PI) / 2.0,
+          (((getThreeState().camera as THREE.PerspectiveCamera).fov / 180.0) *
+            Math.PI) /
+            2.0,
         )) *
-      gl.getSize(rendererSize).height;
+      getThreeState().gl.getSize(rendererSize).height;
   });
   return <points ref={ref} geometry={geometry} material={material} />;
 });