Reset refinements: don't reset theme, more robust scene reset

nerfstudio-project · Jul 17, 2024 · 527b951 · 527b951
1 parent 2913c78
commit 527b951
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/viser/client/src/ControlPanel/GuiState.tsx b/src/viser/client/src/ControlPanel/GuiState.tsx
@@ -135,9 +135,12 @@ export function useGuiState(initialServer: string) {
           }),
         resetGui: () =>
           set((state) => {
+            // No need to overwrite the theme or label. The former especially
+            // can be jarring.
+            // state.theme = cleanGuiState.theme;
+            // state.label = cleanGuiState.label;
+
             // This feels brittle, could be cleaned up...
-            state.theme = cleanGuiState.theme;
-            state.label = cleanGuiState.label;
             state.shareUrl = null;
             state.guiIdSetFromContainerId = {};
             state.modals = [];

diff --git a/src/viser/client/src/SceneTreeState.tsx b/src/viser/client/src/SceneTreeState.tsx
@@ -99,8 +99,8 @@ export function useSceneTreeState() {
                 if (key !== "" && key !== "/WorldAxes")
                   delete state.nodeFromName[key];
               }
-              state.nodeFromName[""]!.children = ["/WorldAxes"];
-              state.nodeFromName["/WorldAxes"]!.children = [];
+              state.nodeFromName[""] = rootNodeTemplate;
+              state.nodeFromName["/WorldAxes"] = rootAxesNode;
             }),
           setLabelVisibility: (name, labelVisibility) =>
             set((state) => {