New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API check for Prom resources #64

Open

martin-magakian wants to merge 1 commit into nerdswords:main from martin-magakian:bug/remove_api_check

martin-magakian commented Jul 8, 2024 •

edited

Loading

Currently we check if the cluster got the ServiceMonitor and PrometheusRule available before installing the resources.

I get the overall idea but I think it will be beneficial to only rely on the user input .serviceMonitor.enabled or .prometheusRule.enabled:

Less confusing: I activated the serviceMonitor but somehow the resource isn't created. Why is that? (I better just fail)
Better 3nd party integration: API check doesn't work well with helm template command. (I actually using Flux who apparently does validation using helm template)
Consistent: I use a lot of helm release yet that the first time I bump into this integration problem. Usually other helm chart doesn't check for the API resource


          Remove API check for Prom resources

cabcafc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet