Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(containerPort): add it as value #62

Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix(containerPort): add it as value #62

merged 3 commits into from
Jun 10, 2024

Conversation

dabcoder
Copy link
Contributor

fixes #20.

helm template <path-to-chart> correctly renders the value.

@dabcoder
Copy link
Contributor Author

cc @cristiangreco

cristiangreco
cristiangreco approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@cristiangreco cristiangreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cristiangreco cristiangreco merged commit f73b17d into nerdswords:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiangreco cristiangreco cristiangreco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard-coded port 5000
2 participants
@dabcoder @cristiangreco