update rpkg commands to print to correct stream on execution #30
Conversation
Signed-off-by: Kushal Harish Naidu <[email protected]>
Signed-off-by: Kushal Harish Naidu <[email protected]>
Signed-off-by: Kushal Harish Naidu <[email protected]>
Signed-off-by: Kushal Harish Naidu <[email protected]>
Signed-off-by: Kushal Harish Naidu <[email protected]>
Signed-off-by: Kushal Harish Naidu <[email protected]>
Signed-off-by: Kushal Harish Naidu <[email protected]>
|
/hold |
@kushnaidu is this PR addressing Issue 562? |
Hey @liamfallon, Yes, it is addressing nephio-project/nephio#562. |
|
Hi @kushnaidu , https://github.com/nephio-project/porch/actions/runs/8171468957/job/22339752701?pr=30#step:9:87 https://github.com/nephio-project/porch/blob/main/test/e2e/cli/testdata/rpkg-clone/config.yaml#L61 To run locally, try to follow the setup done in the github action. kind cluster running, |
Hey @efiacor, |
Signed-off-by: Kushal Harish Naidu <[email protected]>
Signed-off-by: Kushal Harish Naidu <[email protected]>
|
Hey @efiacor , |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, kushnaidu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -163,6 +163,7 @@ func (r *runner) runE(cmd *cobra.Command, args []string) error { | |||
| r.printFnResult(result, printOpt) | |||
| } | |||
| } | |||
| fmt.Fprintf(cmd.OutOrStdout(), "%s pushed\n", packageName) | |||
There was a problem hiding this comment.
Could we put a similar message on 'pull'?
There was a problem hiding this comment.
Could we put a similar message on 'pull'?
Never mind, pull already prints the manifests.
|
Hey @efiacor, |
This change updates the rpkg commands to print to stdout on successful execution instead of stderr.