-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for swimlanes (#162) #164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 96.51% 96.57% +0.05%
==========================================
Files 8 8
Lines 918 933 +15
Branches 69 69
==========================================
+ Hits 886 901 +15
Misses 19 19
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
awesome @psybers thanks a lot |
Wait, I think I forgot one thing: setting the default swimlane on a project. |
@psybers I'm not very familiar with swimlanes, so I don't really understand the problems of not setting the default swimlane on a project. Will you open another pr to address this, or should we release a new version without it? |
I think it is a super small change. There just needs to be one method in Project to set the default swimlane. The API calls def set_default_swimlane(self, id, **attrs):
attrs.update({"default_swimlane": id})
response = self.requester.patch("/projects/" + str(self.id), payload=attrs)
return response.json() I can get another PR in later today. |
I added PR #167 (referencing issue #166) to fix this issue. @protoroto Note that it is not a huge problem, if you release without this additional PR they can still read/write/update swimlanes, they just can't set the default. I'm not sure what Taiga does with no default set, but I suspect the UI would just default to the 'first' (based on order) when adding a new user story. |
Description
Adds support for swimlanes. This adds two new models:
SwimLane
andSwimLanes
. It updates the API client to supportclient.swimlanes.list()
and adds aproject.swimlanes
attribute. You can add new swimlanes viaproject.add_swimlane('name')
.References
Fixes #162
Checklist
inv lint
changes
file included (see docs)