remarkls: make root_dir
more restrictive
#2405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root_dir
more restrictiveThe problem currently is that every time I type a single character, this message pops up aggressively and it switches focus to the pop-up: https://github.com/unifiedjs/unified-language-server/blob/4380a0ffbab401d42e679d2c620aa5b042cfc319/lib/index.js#L201-L210
There is no way to stop this. I have to run
:LspStop remarkls
manually in projects that have markdown but don't use remark (which is most projects).Instead, we look for actual configuration files and only start the LS if they are present. The downside is that remark can also be configured in
package.json
, which wouldn't work with this change (would have to be documented)Alternatives
unified-language-server
.@remcohaszing @wooorm thoughts?