Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two errors:
gmake
always fails due to||
and&&
having the same precedence (missing parentheses):gmake
complains that it's being passed an empty argument when$(GPREFIX)
is empty due to the enclosing quotation marks, removing them fixes it:I was able to build Gitea (https://github.com/go-gitea/gitea) successfully with these changes on current versions of FreeBSD/NetBSD/OpenBSD. I'm not sure if this breaks something on older BSD versions as I'm not very familiar with BSDs (if so, please let me know).